Skip to content

add better input object validation#152

Open
briehl wants to merge 3 commits into
mainfrom
param-validation
Open

add better input object validation#152
briehl wants to merge 3 commits into
mainfrom
param-validation

Conversation

@briehl
Copy link
Copy Markdown
Collaborator

@briehl briehl commented Jan 13, 2026

Adjusts the parameter pydantic model such that:

  • input ids must be UPAs (validated by regex)
  • inputs must exist as objects and be of the right expected type, validated by the workspace.

Closes #151

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.75%. Comparing base (827c66d) to head (9d08720).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
narrative_llm_agent/crews/job_crew.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   57.62%   57.75%   +0.13%     
==========================================
  Files          73       73              
  Lines        5199     5215      +16     
==========================================
+ Hits         2996     3012      +16     
  Misses       2203     2203              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add app parameter input validation step

1 participant